Distro aware checksum #1345
Merged
Distro aware checksum #1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
itzg
approved these changes
Feb 9, 2022
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Awesome! This approach is one of the last pieces of the puzzle to add Alpine to the matrix builds, such as
https://github.com/itzg/docker-minecraft-server/actions/runs/1806504323
Owner
|
...and FYI the final piece in the puzzle: #1349 |
Contributor
Author
|
@itzg might be fun to know that the get distro line was written by GitHub Copilot 😆 |
Owner
|
That is a fun fact especially since I was impressed it can be determined in one shot like that. Oh...I might be thinking of further retrieving the distro version. |
Contributor
Author
|
@itzg This is what Copilot makes of it: # Get distro version
distro_version=$(cat /etc/os-release | grep -E "^VERSION_ID=" | cut -d= -f2 | sed -e 's/"//g')Basically same strategie |
Owner
|
Aha, it's the pre systemd days that I'm remembering...and didn't realize systemd also included os-release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the first problem described in issue #1342. Otherwise the checksum would always be failing on Alpine